Fix the FORM5 optimization regression #477
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts a part of 1d4b775.
tueda
force-pushed
the
fix-optimize-regression
branch
from
232c661 to
cb06ca0
Compare
tueda
force-pushed
the
fix-optimize-regression
branch
from
cb06ca0 to
ba86915
Compare
Collaborator
Author
|
In the change of 1d4b775, why was the code introduced in 0b8f3d7 (with another line) commented out? Why the number of @vermaseren Do you remember this? |
1 task
Collaborator
Author
|
I would bet this is the right fix. (At least "phenomenologically" it works.) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As written in #7 (comment), this reverts a part of 1d4b775, and somehow fixes the optimization regression.
Actually, I understand neither why it fixes the regression nor what was the intention of the change.